Skip to content

🎨 Fix external link icon style (#2221) #2222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KATO-Hiro merged 3 commits into from
Jun 21, 2025
Merged

🎨 Fix external link icon style (#2221) #2222

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
67a8a42
:art: Fix external link icon style (#2221)
KATO-Hiro Jun 21, 2025
b7e9a4d
:art: Replace icon from svg to component (#2221)
KATO-Hiro Jun 21, 2025
cc166ee
:art: Fix format and improve accessibility (#2221)
KATO-Hiro Jun 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 0 additions & 24 deletions src/lib/components/ExternalLinkIcon.svelte
View file
Open in desktop

This file was deleted.

6 changes: 3 additions & 3 deletions src/lib/components/ExternalLinkWrapper.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<script lang="ts">
import ExternalLinkIcon from '$lib/components/ExternalLinkIcon.svelte';
import { ExternalLink } from 'lucide-svelte';
interface Props {
url: string;
Expand All @@ -18,7 +18,7 @@
textSize = '',
textColorInDarkMode = 'dark:text-primary-500',
textOverflow = '',
iconSize = 4,
iconSize = 20,
ariaLabel = '',
useInlineFlex = true,
}: Props = $props();
Expand All @@ -36,7 +36,7 @@
</span>

<span class="ml-1.5">
<ExternalLinkIcon size={`w-${iconSize} h-${iconSize}`} />
<ExternalLink class=" text-primary-600 dark:text-gray-300" size={iconSize} />
</span>
</a>

Expand Down
Loading