🔧 Add Node.js v24 to CI (#2246) #2247
Conversation
WalkthroughThe continuous integration workflow was updated to expand the Node.js version matrix for the build job, adding Node.js 24.x alongside the existing 22.x version. This ensures that CI tests and builds are now executed on both Node.js 22.x and 24.x environments. Changes
Sequence Diagram(s)sequenceDiagram
participant Developer
participant GitHub Actions
participant Build Job (Node.js 22.x)
participant Build Job (Node.js 24.x)
Developer->>GitHub Actions: Push code/PR
GitHub Actions->>Build Job (Node.js 22.x): Run build and tests
GitHub Actions->>Build Job (Node.js 24.x): Run build and tests
Build Job (Node.js 22.x)-->>GitHub Actions: Report results
Build Job (Node.js 24.x)-->>GitHub Actions: Report results
GitHub Actions-->>Developer: Show CI results for both Node versions
Assessment against linked issues
Assessment against linked issues: Out-of-scope changesNo out-of-scope changes found. Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/ci.yml (1)
85-90: Optional: keep runtime jobs in sync with the tested versions
previewandproductionjobs are pinned to Node 22 while the build matrix now tests 22 & 24.
If an incompatibility sneaks in that only affects 24, the artefacts promoted bybuildon 24 will never be deployed, so you are safe.
Conversely, if 24 eventually becomes the primary runtime, the deploy jobs will still rebuild on 22 and could mask issues.Consider either:
- node-version: 22 + node-version: 24or parameterising the version in a reusable workflow input to keep everything aligned.
Also applies to: 134-138
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
.github/workflows/ci.yml(1 hunks)
🔇 Additional comments (1)
.github/workflows/ci.yml (1)
30-33: Confirm availability & ecosystem compatibility for Node 24.xGreat to see the matrix extended – this will surface breaking changes early.
Node 24 is still very new; some GitHub runners or dependencies (e.g. Prisma / pnpm plug-ins) may lag behind.
- Ensure
actions/setup-node@v4already offers pre-built Node 24 binaries – otherwise the job will fail before it starts.- Verify that your lockfile and critical deps build successfully on 24 (the matrix will catch this, but better to run locally first).
- If you intend to allow-fail on 24 during the transition, add an
include/excludeorcontinue-on-errorclause.
|
sveltejs/adapter-vercel が v24に対応していないため、buildが失敗しています。 一旦、close します。 |
close #2246
Summary by CodeRabbit