-
-
Notifications
You must be signed in to change notification settings - Fork 10
💥 Bump pnpm from 10.12.1 to 10.13.1 (#2324) #2325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe Changes
Assessment against linked issues
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the project’s pnpm version in both devDependencies and the packageManager field to 10.13.1 to close issue #2324.
- Bump pnpm dependency from 10.12.4 to 10.13.1
- Sync
packageManagerentry to [email protected]
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
package.json (1)
88-92: MovepnpmtodevDependencies(or drop it entirely).Shipping the package-manager binary as a runtime dependency increases your production bundle size and install time while offering no benefit at runtime.
Either rely solely on the"packageManager"field (Corepack) or keeppnpmunderdevDependencies.@@ "devDependencies": { ... + "pnpm": "10.13.1", ... }, "dependencies": { ... - "pnpm": "10.13.1", ... }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (1)
package.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build (22.x)
🔇 Additional comments (1)
package.json (1)
98-101: Verify engine compatibility & lock-file regeneration.
pnpm10.13.1 requires Node ≥ 18.12, which your"engines"field (>= 18.16.0) satisfies.
Please regeneratepnpm-lock.yamlto freeze the new resolver output and avoid CI drift.
close #2324
Summary by CodeRabbit