Skip to content

🎨 Fix table cell width (#1527) #2384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KATO-Hiro merged 4 commits into from
Jul 26, 2025
Merged

🎨 Fix table cell width (#1527) #2384

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
304d43c
:art: Fix table cell width (#1527)
KATO-Hiro Jul 26, 2025
3dbe362
:art: Remove dulpicated class (#1527)
KATO-Hiro Jul 26, 2025
742ae77
:art: Remove dulpicated class (#1527)
KATO-Hiro Jul 26, 2025
fca9b52
:art: Fix format (#1527)
KATO-Hiro Jul 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions src/lib/components/WorkBookTasks/WorkBookTasksTable.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,8 +150,8 @@
<Table shadow class="text-md table-fixed w-full" aria-label="Workbook tasks">
<caption class="sr-only">List of workbook tasks with their grades and comments</caption>
<TableHead class="text-sm bg-gray-100">
<TableHeadCell class="w-6 pl-2 md:pl-4 pr-0 text-center">#</TableHeadCell>
<TableHeadCell class="w-20 xs:w-24 text-center px-0" aria-label="Task grade">
<TableHeadCell class="w-10 pl-3 pr-3 text-center">#</TableHeadCell>
<TableHeadCell class="w-16 xs:w-20 text-center px-0" aria-label="Task grade">
グレード
</TableHeadCell>
<TableHeadCell class="w-1/2 pl-0 truncate">問題名</TableHeadCell>
Expand All @@ -168,17 +168,15 @@
{#each workBookTasksForTable as task, index}
<TableBodyRow>
<!-- ID -->
<TableBodyCell
class="xs:text-lg text-gray-700 dark:text-gray-300 truncate pl-2 md:pl-4 pr-0"
>
<div class="flex justify-center items-center">
<TableBodyCell class="xs:text-lg text-gray-700 dark:text-gray-300 truncate pl-6 pr-3">
<div class="flex justify-center items-center h-full">
<!-- HACK: 1-indexedにしているが、0-indexedで揃えた方がいい? -->
{index + 1}
</div>
</TableBodyCell>

<!-- グレード -->
<TableBodyCell class="w-20 xs:w-24">
<TableBodyCell>
<div class="flex items-center justify-center">
<GradeLabel taskGrade={getTaskGrade(tasksMapByIds, task.taskId)} />
</div>
Expand Down
Loading