Skip to content

expose add-temporary-group-member command in zms-cli#3184

Merged
psasidhar merged 1 commit intomasterfrom
temp-group-member
Jan 30, 2026
Merged

expose add-temporary-group-member command in zms-cli#3184
psasidhar merged 1 commit intomasterfrom
temp-group-member

Conversation

@havetisyan
Copy link
Copy Markdown
Collaborator

@havetisyan havetisyan commented Jan 29, 2026

Description

Contribution Checklist:

  • The pull request does not introduce any breaking changes
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Attach Screenshots (Optional)

Signed-off-by: Henry Avetisyan <hga@yahooinc.com>
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @havetisyan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the zms-cli tool by introducing a new command that facilitates the management of temporary group memberships. This feature allows administrators to grant time-limited access to users or services within groups, improving security and compliance by ensuring access is automatically revoked after a specified period. The changes involve updating the command-line interface to recognize and process the new command, as well as implementing the underlying logic to handle the expiration dates for group members.

Highlights

  • New Command Introduced: A new command, add-temporary-group-member, has been added to the zms-cli tool, allowing users to add group members with a specified expiration date.
  • Expiration Date Support: The new command supports an expiration parameter, which is a timestamp in yyyy-mm-ddThh:mm:ss.msecZ format, to define the duration of the temporary membership.
  • Core Logic for Temporary Members: A new function, AddDueDateGroupMember, has been implemented in group.go to handle the creation and persistence of group memberships with due dates.
  • CLI Help and Documentation Updates: The zms-cli help messages and command listings have been updated to include the syntax, parameters, and examples for the new add-temporary-group-member command.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the add-temporary-group-member command to zms-cli, allowing users to add members to a group with an expiration date. The changes are well-structured, including the new command logic, a corresponding function in group.go, and updates to the help documentation. I've provided two suggestions to enhance code readability and conciseness by following common Go idioms.

@psasidhar psasidhar merged commit 6e48cc9 into master Jan 30, 2026
8 checks passed
@psasidhar psasidhar deleted the temp-group-member branch January 30, 2026 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants