domain filter support in S3 ChangeLogStore

[havetisyan]

Description

can be used when ZTS instance is only configured to issue user certificates #3239

Contribution Checklist:

• The pull request does not introduce any breaking changes
• I have read the contribution guidelines.
• Create an issue and link to the pull request.

Attach Screenshots (Optional)

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the S3ChangeLogStore by introducing a domain filtering mechanism. This feature allows administrators to specify a subset of domains that the ZTS instance should monitor, which is particularly beneficial for deployments where the ZTS is specialized, such as only issuing user certificates. By reducing the number of domains processed, the change aims to decrease the operational load on the ZTS and its underlying datastore, optimizing resource utilization and improving performance for specific use cases.

Highlights

• Domain Filtering in S3ChangeLogStore: Introduced a new configuration property athenz.zts.s3_change_log_store_domain_filter to allow filtering of domains processed by the S3ChangeLogStore. This enables ZTS instances configured solely for user certificates to reduce their load by only monitoring specific domains.
• Configuration and Initialization: The S3ChangeLogStore now initializes a domainFilter set from a comma-separated system property. It handles cases with spaces and ensures that an empty filter configuration results in no filtering.
• Filtering Logic: The listObjects method in S3ChangeLogStore was updated to skip domains that are not present in the configured domainFilter, if the filter is active.
• Comprehensive Unit Tests: Added extensive unit tests to validate the domain filtering functionality, covering various scenarios such as multiple domains, domains with spaces, empty filters, single domains, filtering with modification times, hidden objects, and multi-page S3 list responses.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces domain filtering to the S3ChangeLogStore, allowing for more efficient operation in specialized ZTS deployments. The implementation is sound, using a system property to configure a comma-separated list of domains to include. The changes are well-supported by a comprehensive suite of new unit tests that cover various edge cases. My review includes a couple of suggestions to enhance code clarity and maintainability.