support external members in roles and groups

[havetisyan]

Description

external member support in roles and groups #3255

Due to extended type of principal values, the go client library requires changes to the principal argument type to zts.PrincipalName()

Contribution Checklist:

• The pull request does not introduce any breaking changes
• I have read the contribution guidelines.
• Create an issue and link to the pull request.

Attach Screenshots (Optional)

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces robust support for external members within Athenz roles and groups. It provides the necessary data model extensions, API updates, and validation mechanisms to seamlessly integrate external identities, allowing for more flexible and secure access management across different user bases.

Highlights

• New Principal Types: Introduced ExternalMemberName and PrincipalName RDL types and their corresponding Go and Java definitions, enabling explicit representation of external identities within the system.
• API Parameter Updates: Updated ZMS and ZTS client and schema definitions to utilize the new PrincipalName type for principal-related API parameters, enhancing type safety and clarity across various access and membership queries.
• Principal Type Extension: Extended the Principal.Type enum in auth_core to include EXTERNAL(5), allowing the system to categorize external members distinctly for internal processing and logic.
• External Member Validation: Implemented ExternalEmailMemberValidator for ZMS, providing a configurable mechanism to validate external email addresses, including support for domain restrictions, ensuring only authorized external identities can be added.
• Core Logic Enhancements: Modified ZMS and ZTS core logic to correctly process, validate, and manage external members in roles and groups, including handling of wildcard patterns in member names and proper application of principal state updates.
• Comprehensive Testing: Added extensive unit and integration tests across ZMS and ZTS to ensure proper functionality and validation of external member support in various scenarios, including access checks, group/role membership, and state management.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces support for external members in Athenz, defining new ExternalMemberName and PrincipalName types across ZMS and ZTS clients and schemas. It updates API endpoints to use these new types, extends the Principal.Type enum, and adds an ExternalEmailMemberValidator. Core logic in ZMS and ZTS is modified to handle external members in roles, groups, access checks, and principal state management. New unit tests validate this functionality. Review comments highlight critical issues in principal parsing logic within JDBCConnection.java and PrincipalUtils.java, and a resource leak in test cleanup for ExternalMemberValidatorManager.