support external members in roles and groups#3263
Conversation
Signed-off-by: Henry Avetisyan <hga@yahooinc.com>
|
Warning Gemini is experiencing higher than usual traffic and was unable to create the review. Please try again in a few hours by commenting |
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces support for external members across Athenz components, including schema updates, client/server modifications, and new validation logic. The changes involve adding new types like ExternalMemberName and PrincipalName, updating access check logic, and implementing a validator for external email members. Feedback suggests improving error handling in ZMSImpl.java by returning a 400 Bad Request instead of a 401 Unauthorized when an invalid principal name is provided, ensuring consistency with other parts of the codebase.
Signed-off-by: Henry Avetisyan <hga@yahooinc.com>
Description
support external members in roles and groups #3255
the go client requires changes to switch to PrincipalName syntax to support the new external members.
Contribution Checklist:
Attach Screenshots (Optional)