Skip to content

support external members in roles and groups#3263

Merged
psasidhar merged 2 commits intomasterfrom
ext-member-support
Mar 26, 2026
Merged

support external members in roles and groups#3263
psasidhar merged 2 commits intomasterfrom
ext-member-support

Conversation

@havetisyan
Copy link
Copy Markdown
Collaborator

@havetisyan havetisyan commented Mar 26, 2026

Description

support external members in roles and groups #3255

the go client requires changes to switch to PrincipalName syntax to support the new external members.

Contribution Checklist:

  • The pull request does not introduce any breaking changes
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Attach Screenshots (Optional)

Signed-off-by: Henry Avetisyan <hga@yahooinc.com>
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Warning

Gemini is experiencing higher than usual traffic and was unable to create the review. Please try again in a few hours by commenting /gemini review.

@havetisyan
Copy link
Copy Markdown
Collaborator Author

/gemini review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for external members across Athenz components, including schema updates, client/server modifications, and new validation logic. The changes involve adding new types like ExternalMemberName and PrincipalName, updating access check logic, and implementing a validator for external email members. Feedback suggests improving error handling in ZMSImpl.java by returning a 400 Bad Request instead of a 401 Unauthorized when an invalid principal name is provided, ensuring consistency with other parts of the codebase.

Signed-off-by: Henry Avetisyan <hga@yahooinc.com>
@psasidhar psasidhar merged commit 2f2baa9 into master Mar 26, 2026
8 checks passed
@psasidhar psasidhar deleted the ext-member-support branch March 26, 2026 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants