extract the external domain prefix before calling validatMember method#3268
Open
havetisyan wants to merge 1 commit intomasterfrom
Open
extract the external domain prefix before calling validatMember method#3268havetisyan wants to merge 1 commit intomasterfrom
havetisyan wants to merge 1 commit intomasterfrom
Conversation
Signed-off-by: Henry Avetisyan <hga@yahooinc.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the external member validation logic to ensure only the actual member name, excluding the external prefix, is passed to the validator. Key changes include the introduction of a validateExternalMember helper in ZMSImpl, enhanced error logging in ExternalEmailMemberValidator using SLF4J, and updated unit tests to verify correct prefix stripping and error handling for various input formats. I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
external member validation update - #3255
Contribution Checklist:
Attach Screenshots (Optional)