Skip to content

[Snyk] Security upgrade node-sass from 6.0.1 to 9.0.0 #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
karimkawambwa wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Security upgrade node-sass from 6.0.1 to 9.0.0 #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"compression-webpack-plugin": "9",
"css-loader": "^6.2.0",
"mini-css-extract-plugin": "^2.1.0",
"node-sass": "^6.0.1",
"node-sass": "^9.0.0",
Copy link
Copy Markdown

@sentry sentry bot Jan 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The yarn.lock file is out of sync with package.json. This will cause the old, vulnerable version of node-sass to be installed, negating the security fix.
Severity: CRITICAL | Confidence: High

🔍 Detailed Analysis

The package.json file was updated to change the node-sass dependency from version ^6.0.1 to ^9.0.0 to fix a high-severity vulnerability. However, the yarn.lock file was not regenerated. As a result, any yarn install command, whether run by developers or in a CI/CD pipeline, will prioritize the lockfile and install the old, vulnerable version 6.0.1. This completely negates the security fix this pull request is intended to deliver, leaving the application exposed to the vulnerability.

💡 Suggested Fix

Run yarn install or an equivalent command to regenerate the yarn.lock file based on the changes in package.json. Commit the updated yarn.lock file to the pull request.

🤖 Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: package.json#L17

Potential issue: The `package.json` file was updated to change the `node-sass`
dependency from version `^6.0.1` to `^9.0.0` to fix a high-severity vulnerability.
However, the `yarn.lock` file was not regenerated. As a result, any `yarn install`
command, whether run by developers or in a CI/CD pipeline, will prioritize the lockfile
and install the old, vulnerable version `6.0.1`. This completely negates the security
fix this pull request is intended to deliver, leaving the application exposed to the
vulnerability.

Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 8136148

"postcss": "^8.3.6",
"postcss-import": "^14.0.2",
"postcss-loader": "^6.1.1",
Expand Down