More Linux integration#1085
Merged
stonedDiscord merged 8 commits intoAttorneyOnline:masterfrom Mar 17, 2025
Merged
Conversation
Contributor
lambdcalculus
commented
Feb 27, 2025
lambdcalculus
commented
- Patch the ELF file to automatically use the running directory as a linker path, removing the need for a launch script. Trying to run the executable from a different directory can still fail but that doesn't matter, because...
- Desktop files! Credit to @OrioleNix for the idea from Add integration shell scripts for linux! #1082. Linux builds of AO now come with install scripts for desktop files, allowing users to easily launch AO from app launchers.
- There's also a few small tweaks to the CI, like the AO tar extracting to a folder called "Attorney Online" instead of "Attorney_Online."
These shell scripts (one for appimage and one for dynamic) both should: 1: Move the program files to ~/.local/Attorney_Online 2: Create a .desktop file (which is what applications on Linux use to know to be interacted with) in the ~/.local/share/applications folder (where all other user applications tend to go), with at current a temporary logo until the logo file is parsed out from the xapplication window. 3: open the application, assuming the necessary dependencies are fulfilled Dynamic required some further support due to the startup shell command working correctly when you click it manually, but struggling on the .desktop folder, so it has the additional step of recreating the current launch.sh command, which still functions if you go to the folder to click it, or if you open the program before integration to test things. Both sh commands open AO2-Client at completion time. I hope this will help newer Linux users, or older Linux users who normally wouldn't bother, to bring AO into their normal day to day experience. This has been tested on (by me): Fedora 40 Workstation (Gnome) Arch Linux KDE Plasma 6 Ubuntu Unity 24.10 aka Oracular Oriole Debian 13 Trixie (Before it's freeze, marking date February 9th 2025) Thank you for reading, have a wonderful day!
* remove the need for `launch.sh` * add git hash as appimage version * bit of reorganization
* tweak linux install scripts to add install scripts * remove `launch.sh` (as per previous commit) * add instructions in README_LINUX
and fix typo
Contributor
|
Thank you for carrying on my work! I may or may not have gotten sick right after doing the first snippets, im sure people will love it! |
stonedDiscord
approved these changes
Mar 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.