Open
Conversation
Most people report via ID, and not being able to see it and having to go on to check is odd. Also re-orders the arguments so the sample properly has 1 through 7 args in sequence since thats what the default is. This will be superseded by the packet rework in some future time, but it will do if that is not the near future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most people report via ID, and not being able to see it and having to manually check is odd.
Also re-orders the arguments so the config_sample properly has 1 through 7 args in sequence since that is what the default is.
This will be superseded by the packet rework in some future time, but it will do if that is not the near future.