Skip to content

A few fixes suggested by Clippy #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mgeier merged 1 commit into from
Dec 19, 2025
Merged

A few fixes suggested by Clippy #64

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 22 additions & 18 deletions src/parser/elements.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,16 +452,18 @@ impl<'a> Element<'a> for SeqElement {
let mut files = Vec::new();
let mut transformers = Vec::new();
for i in 0..self.iterations.get() {
files.extend(self.files.iter().cloned().map(|entry| PlaylistEntry {
files.extend(self.files.iter().map(|entry| PlaylistEntry {
begin: i * self.end + entry.begin,
..entry
}));
transformers.extend(self.transformers.iter().cloned().map(|instance| {
TransformerInstance {
begin: i * self.end + instance.begin,
..instance
}
..*entry
}));
transformers.extend(
self.transformers
.iter()
.map(|instance| TransformerInstance {
begin: i * self.end + instance.begin,
..*instance
}),
);
}
parent.unwrap().add_files_and_transformers(
files,
Expand Down Expand Up @@ -550,16 +552,18 @@ impl<'a> Element<'a> for ParElement {
let mut files = Vec::new();
let mut transformers = Vec::new();
for i in 0..self.iterations.get() {
files.extend(self.files.iter().cloned().map(|entry| PlaylistEntry {
files.extend(self.files.iter().map(|entry| PlaylistEntry {
begin: i * duration + entry.begin,
..entry
}));
transformers.extend(self.transformers.iter().cloned().map(|instance| {
TransformerInstance {
begin: i * duration + instance.begin,
..instance
}
..*entry
}));
transformers.extend(
self.transformers
.iter()
.map(|instance| TransformerInstance {
begin: i * duration + instance.begin,
..*instance
}),
);
}
parent.unwrap().add_files_and_transformers(
files,
Expand Down Expand Up @@ -1327,10 +1331,10 @@ impl<'a> Element<'a> for TransformElement {

let mut duplicated_transformers = Vec::new();
for i in 0..self.iterations.get() {
duplicated_transformers.extend(transformers.iter().cloned().map(|instance| {
duplicated_transformers.extend(transformers.iter().map(|instance| {
TransformerInstance {
begin: i * frames + instance.begin,
..instance
..*instance
}
}));
}
Expand Down