privateCollapseAndCollapseChildren: fix#245
Open
simple-user wants to merge 1 commit intoAugustyniak:masterfrom
Open
privateCollapseAndCollapseChildren: fix#245simple-user wants to merge 1 commit intoAugustyniak:masterfrom
privateCollapseAndCollapseChildren: fix#245simple-user wants to merge 1 commit intoAugustyniak:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After expand and collapse a cell I have an issue with
cellForItem:for its child cells. After cell is collapsed without collapseChildren option, child cells are not invalidated, andindexPathForItem:returns valid indexPath, socellForItem:returns incorrect cell (one from below).This caused a lot of unexpected behavior.
This is the simplest solution: still assing
setExpanded:NOonly in case it is expected, but invalidate all hierarchy of children every time.