port updateExtensionAuthenticationRequest#61
Merged
wparad merged 2 commits intoAuthress:release/3.0from Dec 21, 2025
Merged
Conversation
cranberyxl
force-pushed
the
feature/updateExtensionAuthenticationRequest
branch
3 times, most recently
from
17f2d5d to
316cbaa
Compare
cranberyxl
force-pushed
the
feature/updateExtensionAuthenticationRequest
branch
from
316cbaa to
fbf15b7
Compare
wparad
requested changes
Dec 10, 2025
Member
wparad
left a comment
wparad
left a comment
There was a problem hiding this comment.
I'm marking this as request changes, but realistically, these changes are something I expect us to do before merging on top of this PR. I'm not expecting you to go through and make these updates.
wparad
force-pushed
the
feature/updateExtensionAuthenticationRequest
branch
2 times, most recently
from
e40f7f9 to
eec8ed0
Compare
wparad
approved these changes
Dec 21, 2025
wparad
force-pushed
the
feature/updateExtensionAuthenticationRequest
branch
from
eec8ed0 to
988cb6e
Compare
wparad
force-pushed
the
feature/updateExtensionAuthenticationRequest
branch
from
988cb6e to
bf17f2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From: https://github.com/Authress/authress-login.js/blob/release/2.6/src/index.js#L441
Allows this redirection to happen on the server and not be dependent on browser javascript.