Fix build + start client in asynchronous mode#666
Open
GDB4J wants to merge 2 commits intoAuties00:masterfrom
Open
Fix build + start client in asynchronous mode#666GDB4J wants to merge 2 commits intoAuties00:masterfrom
GDB4J wants to merge 2 commits intoAuties00:masterfrom
Conversation
Owner
|
Use virtual threads instead of completabile future, that's why |
Contributor
Author
Indeed! That's the reason why i think a new method would be nice to be able to start / run the client asynchronous ... therefore my proposal Ps I am currently not able to send images / media with the current master branch, is this part supposed to be already working? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix build
Build is currently failing due to a misplaced and duplicated
namemethod in the Web builder.Probably due to my contribution earlier of the
namemethod in the Web builder.Start the client in a asynchronous way
There seems currently no way to start the client in a asynchronous, which was earlier on possible with the
joinmethod.Since the refactorring, this seems no longer possible, but it is still a nice feature to provide.
Therefore I've proposed a method
asyncin theWhatsAppClientclass to start the client in a new virtual thread.Please review.
Thanks,
KR