Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for additional tags to be applied to all AWS resources created by the module. Users can now specify custom tags through the additional_tags variable, which are merged with the default tags (automqVendor and automqEnvironmentID) and applied consistently across all resources.
- Added
additional_tagsvariable to enable external tag specification - Implemented centralized tag management using a
common_tagslocal variable - Updated all resource tag definitions to use the centralized tagging approach
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| variables.tf | Added additional_tags variable definition |
| main.tf | Updated EC2 instance and EBS volume resources to use centralized tagging |
| aws.tf | Implemented common_tags local variable and updated all AWS resources to use centralized tagging |
| README.md | Added usage example demonstrating the additional_tags feature |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
b6a299c to
fc55087
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables users to add custom tags like Environment, Project, Owner, etc. to all AWS resources created by this module.