Replace hardcoded value with class constant and bump the limit to 11k #406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rinatkhaziev
force-pushed
the
update/max-site-limit
branch
from
e8bd6ab to
61cd15d
Compare
sjinks
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slightly increase the maximum allowed sizes value and make it a constant.
This pull request introduces a configurable constant to manage the maximum number of subsites supported in a multisite environment, replacing hardcoded values. The changes improve maintainability and make it easier to adjust the limit in the future.
Introduction of
MAX_SITESconstant:includes/wp-cli/class-orchestrate-sites.php: Added a new constantMAX_SITESwith a value of11000to define the maximum number of supported subsites. This replaces the previously hardcoded value of10000.Refactoring to use
MAX_SITES:includes/wp-cli/class-orchestrate-sites.php: Updated thedisplay_sitesmethod to use theMAX_SITESconstant in the subsite count check and theget_sitesquery, ensuring consistency and easier future updates.