Skip to content
This repository was archived by the owner on Aug 21, 2025. It is now read-only.

[Tooling] Add Danger setup#71

Merged
iangmaia merged 2 commits intotrunkfrom
iangmaia/add-danger-config
Jul 23, 2025
Merged

[Tooling] Add Danger setup#71
iangmaia merged 2 commits intotrunkfrom
iangmaia/add-danger-config

Conversation

@iangmaia
Copy link
Contributor

@iangmaia iangmaia commented Jul 22, 2025

Fixes AINFRA-982

Description

This PR adds Danger to the project so that we can run PR checks.

For now, I've only added the following checks:

  • Rubocop
  • Gemfile / Gemfile.lock consistency
  • Labels check (Do Not Merge label will fail CI).

Testing Steps

We can trigger / remove a Danger violation by setting the Do Not Merge label.

@iangmaia iangmaia self-assigned this Jul 22, 2025
@iangmaia iangmaia marked this pull request as ready for review July 22, 2025 12:07
@iangmaia iangmaia force-pushed the iangmaia/add-danger-config branch from d9823ee to f346fb3 Compare July 22, 2025 12:11
@iangmaia iangmaia requested a review from a team July 22, 2025 12:45
@AliSoftware
Copy link
Contributor

nit: Do we need a Linear issue reference linked to this PR?

@iangmaia iangmaia force-pushed the iangmaia/add-pr-prototype-build branch 2 times, most recently from 1a26327 to 135b12c Compare July 22, 2025 20:00
Base automatically changed from iangmaia/add-pr-prototype-build to trunk July 22, 2025 20:11
@iangmaia iangmaia force-pushed the iangmaia/add-danger-config branch from e0d1927 to 6126bec Compare July 23, 2025 08:36
@iangmaia iangmaia enabled auto-merge July 23, 2025 08:39
@iangmaia iangmaia merged commit d2b07e5 into trunk Jul 23, 2025
9 of 11 checks passed
@iangmaia iangmaia deleted the iangmaia/add-danger-config branch July 23, 2025 08:44
@wpmobilebot
Copy link

wpmobilebot commented Jul 23, 2025

📲 You can test the changes from this Pull Request in Gravatar Android by scanning the QR code below to install the corresponding build.
App NameGravatar Android
Build Typerelease
Commit6126bec
Direct Downloadgravatar-app-prototype-build-pr71-6126bec.apk

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants