Share tab header with the menu button#73
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements the Share tab header layout with a menu button and introduces a reusable blurred header background component. The implementation adds a QR code placeholder area and menu functionality while extracting common background styling for consistency across tabs.
- Adds QR code placeholder and menu button to Share tab header
- Extracts BlurredHeaderBackground component for reuse across headers
- Integrates avatar URL fetching in ShareViewModel for the header background
Reviewed Changes
Copilot reviewed 9 out of 21 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| ShareHeader.kt | Complete redesign with QR code area, menu button, and proper layout structure |
| BlurredHeaderBackground.kt | New reusable component for consistent header backgrounds with semi-transparent overlay |
| ShareViewModel.kt | Adds avatar URL collection for header background |
| ShareUiState.kt | Adds avatarUrl property to state |
| ShareScreen.kt | Passes avatar URL to ShareHeader component |
| AnimatedProfileHeader.kt | Refactored to use new BlurredHeaderBackground component |
| GravatarHeader.kt | Refactored to use new BlurredHeaderBackground component |
| strings.xml | Adds QR code description string |
| ShareHeaderTest.kt | Adds basic screenshot test for the new header |
...Ui/src/main/kotlin/com/gravatar/app/homeUi/presentation/home/share/components/ShareHeader.kt
Show resolved
Hide resolved
...Ui/src/main/kotlin/com/gravatar/app/homeUi/presentation/home/share/components/ShareHeader.kt
Show resolved
Hide resolved
44bb995 to
84afa36
Compare
|
The screenshot tests pass locally... |
I wonder why it doesn't work in CI. In both executions, the difference is just 12 pixels in the ProfileScreenTest 🤔 |
I have updated the Roborazzi rule with the same compare options we use in the SDK - it now works fine. |
Description
This PR implements the layout for the Share tab header with the menu button.
Additionally, I've extracted the blurred avatar component so that we can reuse it across all the headers and added a semi-transparent black layer over it to match iOS.
This PR doesn't:
Testing Steps