Skip to content
This repository was archived by the owner on Aug 21, 2025. It is now read-only.

Share tab header with the menu button#73

Merged
AdamGrzybkowski merged 4 commits intotrunkfrom
adam/GRA-575
Jul 23, 2025
Merged

Share tab header with the menu button#73
AdamGrzybkowski merged 4 commits intotrunkfrom
adam/GRA-575

Conversation

@AdamGrzybkowski
Copy link
Contributor

Description

This PR implements the layout for the Share tab header with the menu button.

Additionally, I've extracted the blurred avatar component so that we can reuse it across all the headers and added a semi-transparent black layer over it to match iOS.

This PR doesn't:

  • Implement the QR code. There's a slot for it, though.
  • Add all the buttons. Only menu was added for now, as it's not clear what will be implemented for the first push and we can't have buttons that don't work.
share_header

Testing Steps

  1. Open the app and go to the share tab
  2. Confirm the layout looks like in Figma
  3. Test other headers because of the small structure change

@AdamGrzybkowski AdamGrzybkowski added the enhancement New feature or request label Jul 23, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements the Share tab header layout with a menu button and introduces a reusable blurred header background component. The implementation adds a QR code placeholder area and menu functionality while extracting common background styling for consistency across tabs.

  • Adds QR code placeholder and menu button to Share tab header
  • Extracts BlurredHeaderBackground component for reuse across headers
  • Integrates avatar URL fetching in ShareViewModel for the header background

Reviewed Changes

Copilot reviewed 9 out of 21 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
ShareHeader.kt Complete redesign with QR code area, menu button, and proper layout structure
BlurredHeaderBackground.kt New reusable component for consistent header backgrounds with semi-transparent overlay
ShareViewModel.kt Adds avatar URL collection for header background
ShareUiState.kt Adds avatarUrl property to state
ShareScreen.kt Passes avatar URL to ShareHeader component
AnimatedProfileHeader.kt Refactored to use new BlurredHeaderBackground component
GravatarHeader.kt Refactored to use new BlurredHeaderBackground component
strings.xml Adds QR code description string
ShareHeaderTest.kt Adds basic screenshot test for the new header

@AdamGrzybkowski
Copy link
Contributor Author

The screenshot tests pass locally...

@hamorillo
Copy link

hamorillo commented Jul 23, 2025

The screenshot tests pass locally...

I wonder why it doesn't work in CI. In both executions, the difference is just 12 pixels in the ProfileScreenTest 🤔

Copy link

@hamorillo hamorillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@AdamGrzybkowski
Copy link
Contributor Author

I wonder why it doesn't work in CI. In both executions, the difference is just 12 pixels in the ProfileScreenTest 🤔

I have updated the Roborazzi rule with the same compare options we use in the SDK - it now works fine.

@AdamGrzybkowski AdamGrzybkowski merged commit d5b22ce into trunk Jul 23, 2025
10 of 11 checks passed
@AdamGrzybkowski AdamGrzybkowski deleted the adam/GRA-575 branch July 23, 2025 10:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants