This repository was archived by the owner on Aug 21, 2025. It is now read-only.
AboutAppDialog from the TopMenuPopup#75
Merged
AdamGrzybkowski merged 8 commits intotrunkfrom Jul 24, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements an "About App" dialog accessible through the top menu popup across all tabs where the menu button is visible. The implementation adds new events and UI state handling for showing/dismissing the dialog, along with dependency injection for app version information.
- Adds AboutAppDialog component with app information, support links, and legal links
- Integrates the dialog into all three main tabs (Profile, Gravatar, Share) with consistent state management
- Sets up AppVersion injection from the app module to display version information
Reviewed Changes
Copilot reviewed 28 out of 29 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| AboutAppDialog.kt | New dialog component displaying app version, support links, and legal information |
| TopBarPickerPopup.kt | Adds "About this app" menu item with callback handling |
| Profile/Gravatar/Share ViewModels/Events/UiState | Adds dialog visibility state and event handling for each tab |
| AppVersion.kt | New value class for app version injection |
| BuildConfigModule.kt | DI module providing app version from BuildConfig |
| strings.xml | Adds new string resources for dialog content |
Comments suppressed due to low confidence (1)
...main/kotlin/com/gravatar/app/homeUi/presentation/home/components/topbar/TopBarPickerPopup.kt
Show resolved
Hide resolved
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
AdamGrzybkowski
force-pushed
the
adam/GRA-582
branch
from
d3b0603 to
67a660c
Compare
hamorillo
approved these changes
Jul 24, 2025
| @OptIn(ExperimentalMaterial3Api::class) | ||
| @Composable | ||
| internal fun AboutAppDialog( | ||
| visible: Boolean, |
There was a problem hiding this comment.
I don't usually like this approach, as we are adding an unnecessary composable that will always be there. Not a big deal, I understand that it's convenient in some cases.
Contributor
Author
There was a problem hiding this comment.
No strong opinions here, I removed it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the
AboutAppDialogon all tabs where the menu button is visible.The
AppVersionis injected from the:appmodule.Testing Steps