This repository was archived by the owner on Aug 21, 2025. It is now read-only.
Set keyboardType for email&phone input fields#79
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves the user experience for email and phone input fields by setting appropriate keyboard types that display specialized soft keyboards on mobile devices.
- Adds KeyboardType.Email and KeyboardType.Phone to respective input fields
- Updates ShareEditableField component to accept and handle keyboardType parameter
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| SharePrivateContactInfo.kt | Passes specific keyboard types (Email/Phone) to the email and phone input fields |
| ShareEditableField.kt | Adds keyboardType parameter and applies it to BasicTextField via KeyboardOptions |
...kotlin/com/gravatar/app/homeUi/presentation/home/share/components/SharePrivateContactInfo.kt
Show resolved
Hide resolved
hamorillo
force-pushed
the
adam/keyboard_type
branch
from
fb2c104 to
a94e896
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This will open the soft keyboard in a mode that suits the given input field.
Example for the KeyboardType.Phone
Testing Steps