This repository was archived by the owner on Aug 21, 2025. It is now read-only.
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements local storage persistence for user sharing preferences and refactors the private contact information handling. The changes enable user preferences to persist across app sessions using Android DataStore.
- Adds
UserSharePreferencesStorageinterface with DataStore implementation for persisting share preferences - Introduces new use cases for getting and updating user share preferences with Flow-based reactive updates
- Refactors private contact info handling by separating data model (
PrivateContactInfo) from UI state (PrivateContactState)
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| UpdateUserSharePreferencesUseCase.kt | New use case for updating user share preferences with storage persistence |
| GetUserSharePreferencesUseCase.kt | New use case for retrieving user share preferences as a Flow with distinct updates |
| UserSharePreferences.kt | Enhanced data model with private email/phone fields and default values |
| PrivateContactInfo.kt | New domain model for private contact information separate from UI state |
| UserComponentModule.kt | Dependency injection setup for new use cases |
| DatastoreModule.kt | DataStore configuration for UserSharePreferencesStorage |
| UserPrefsStorage.kt | DataStore implementation with preference keys and serialization logic |
| ShareViewModel.kt | Updated to use new use cases and handle preference persistence |
| ShareUiState.kt | Refactored to separate domain models from UI state representation |
| Various test files | Updated tests to use new models and default values |
| * Convenient interface to clear all user related data in one call. | ||
| */ | ||
| internal interface UserStorage : AuthTokenStorage, AvatarCacheBusterStorage { | ||
| internal interface UserStorage : AuthTokenStorage, AvatarCacheBusterStorage, UserSharePreferencesStorage { |
There was a problem hiding this comment.
The UserStorage interface is inheriting from UserSharePreferencesStorage, but the clear() method doesn't explicitly clear user share preferences. This could lead to inconsistent behavior where auth tokens and cache busters are cleared but share preferences persist.
homeUi/src/main/kotlin/com/gravatar/app/homeUi/presentation/home/share/ShareViewModel.kt
Show resolved
Hide resolved
homeUi/src/main/kotlin/com/gravatar/app/homeUi/presentation/home/share/ShareViewModel.kt
Show resolved
Hide resolved
hamorillo
force-pushed
the
adam/GRA-577
branch
2 times, most recently
from
c58098a to
f5c853f
Compare
hamorillo
approved these changes
Jul 28, 2025
|
|
||
| private val tokenKey = stringPreferencesKey(AUTH_TOKEN_KEY) | ||
| private val avatarCacheBusterKey = stringPreferencesKey(AVATAR_CACHE_BUSTER_KEY) | ||
| private val userShareNameKey = booleanPreferencesKey(USER_SHARE_NAME_KEY) |
There was a problem hiding this comment.
💡 This is growing fast. Not for this PR, but we may consider splitting it up.
# Conflicts: # homeUi/src/main/kotlin/com/gravatar/app/homeUi/presentation/home/share/components/SharePrivateContactInfo.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds local storage for the
UserSharePreferences.Additionally (in the 2nd commit), I've remodeled a bit how the ShareUiState is built with the private contact info and added the private phone/email share prefs to the
UserSharePreferencesas well. The newPrivateContactInfofrom:userComponentshould be used in the next PRs to get/update those values.Testing Steps