This repository was archived by the owner on Aug 21, 2025. It is now read-only.
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a private information dialog to the Share screen that explains how email and phone numbers are shared via QR code only and not stored publicly. The PR also extracts common dialog components to the design module for reusability.
- Adds
PrivateInformationDialogcomponent with explanatory text and "Got it" button - Makes the private contact info section title clickable to trigger the dialog
- Extracts common dialog components (
GravatarDialog,DialogTitle,DialogText,PrimaryButton) to the design module - Updates
AboutAppDialogto use the new shared dialog components
Reviewed Changes
Copilot reviewed 15 out of 17 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
SharePrivateContactInfo.kt |
Makes section title clickable to show dialog |
PrivateInformationDialog.kt |
New dialog component explaining private information handling |
ShareViewModel.kt |
Adds state management for dialog visibility |
ShareUiState.kt |
Adds dialog visibility flag to UI state |
ShareScreen.kt |
Integrates dialog into screen composition |
ShareEvent.kt |
Adds events for dialog show/dismiss |
AboutAppDialog.kt |
Refactored to use extracted dialog components |
design/components/dialog/ |
New shared dialog components |
design/components/button/PrimaryButton.kt |
New shared button component |
| Test files | Updated tests for new functionality |
strings.xml |
Added dialog text strings |
...otlin/com/gravatar/app/homeUi/presentation/home/share/components/PrivateInformationDialog.kt
Outdated
Show resolved
Hide resolved
AdamGrzybkowski
force-pushed
the
adam/GRA-594
branch
from
d6b4742 to
2b81617
Compare
# Conflicts: # homeUi/src/main/kotlin/com/gravatar/app/homeUi/presentation/home/share/ShareScreen.kt # homeUi/src/main/kotlin/com/gravatar/app/homeUi/presentation/home/share/ShareUiState.kt # homeUi/src/main/kotlin/com/gravatar/app/homeUi/presentation/home/share/ShareViewModel.kt # homeUi/src/main/res/values/strings.xml # homeUi/src/test/kotlin/com/gravatar/app/homeUi/presentation/home/share/ShareViewModelTest.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the
PrivateInformationDialogto the Share screen.Additionally, I've extracted common dialog components and the dialog itself to the
:designmodule.Testing Steps