Fix Windows tests #196
Fix Windows tests #196
Conversation
iangmaia
force-pushed
the
iangmaia/fix-windows-test
branch
from
48d49bc to
58e82ef
Compare
iangmaia
requested review from
AliSoftware and
mokagio
and removed request for
AliSoftware
AliSoftware
left a comment
AliSoftware
left a comment
There was a problem hiding this comment.
Overall my suggestion for the fix is to just completely delete the prepare_windows_host_for_app_distribution.ps1 and its test from the repo.
Once we'll find the time to update all the repos that were still calling prepare_windows_host_for_app_distribution.ps1 in their .buildkite/commands/*.sh scripts and relied on the assumption that they might still be running on the base AMI and not our custom one, we'll have those repos just call setup_windows_code_signing.ps1 directly instead and bump their release-toolkit version to 6.0.0, at which point no repo using release-tookit >5.7.0 will call prepare_windows_host_for_app_distribution.ps1 and it won't be needed anymore (which was the whole point of creating our custom AMI in the first place after all.
h/t @AliSoftware #196 (comment) -- this is now done in the AMI itself. Since this plugin is versioned and apps use a pinned version, we can safely remove the scripts.
|
Also feel free to make this PR target Once we merge this PR I can rebase my |
h/t @AliSoftware #196 (comment) -- this is now done in the AMI itself. Since this plugin is versioned and apps use a pinned version, we can safely remove the scripts.
Co-authored-by: Olivier Halligon <olivier.halligon@automattic.com>
iangmaia
force-pushed
the
iangmaia/fix-windows-test
branch
from
ccb2cb7 to
1e40f20
Compare
As reported in #195, Windows unit tests started failing, presumably after all the changes in our Windows AMI.
This PR should fix the Windows unit tests.