fix: scope module asset loading to post management pages #858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Module assets (CSS/JS) were loading on every admin page because is_whitelisted_functional_view() always returned true. This was wasteful and caused unnecessary resource loading. Implement is_post_management_page() to properly check if we're on a post management page (post.php, post-new.php, edit.php) before loading module assets. Optionally validates the current post type is supported by the module. Closes #351 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
is_post_management_page()method to properly scope module asset loadingBackground
The old
is_whitelisted_functional_view()method always returnedtruewith a@todocomment, meaning module assets loaded on every admin page unnecessarily. This caused wasteful resource loading on pages like the dashboard, plugins page, and settings pages where Edit Flow functionality isn't needed.This takes the simpler "module-by-module" approach suggested in the comments of the previously closed #487, rather than attempting a global change that could break functionality.
Test plan
Closes #351
🤖 Generated with Claude Code