feat(core): create rule to enforce sentence case #2372
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for creating Harper, which looks great! The most common challenge we're facing around grammar in our code base is to enforce consistent use of sentence casing (i.e., prevent the use of title case in headings), and I am hoping harper can help with that. But I didn't see a rule to check for sentence case capitalization.
I don't usually write Rust and this feature was mainly implemented by Cursor. I don't necessarily expect this PR to be merged but perhaps it can serve as a starting point or basis for discussion.
Issues
None, afaict.
Description
This PR adds a rule enforcing sentence case, including in headings. It checks whether every capitalized word is either a proper noun, at the beginning of a sentence, or preceded by a quote or sentence terminator. The rule disabled by default.
Demo
None
How Has This Been Tested?
In addition to (automatically written) unit tests, I compiled harper.js and ran some manual tests with it.
Checklist