feat(core): introduce Weirpacks #2491
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Hmm this could mean I could contribute more "opinionated" rules that don't have to default to "on". Will keep it in mind. |
Collaborator
Author
Precisely. |
elijah-potter
force-pushed
the
weirpacks
branch
from
2539be7 to
6d9fd14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See my recent blog post for the full context: https://elijahpotter.dev/articles/imagine-a-weir-marketplace
In short: With Weir making it easier to write rules and otherwise extend Harper, it would be useful to be able to share collections of rules with other users. To that end, I've defined "Weirpack" to be a shareable file containing collections of Harper rules.
I've set up the infrastructure to read and write Weirpacks, including changes to
harper-core,harper.js, and an interactive playground available at the/weir/playgroundendpoint.I intend to follow up on this PR with improvements to the Weir interpreter and ways to load Weirpacks from disk and over the network.
Demo
How Has This Been Tested?
Mostly manually. This PR will remain not be merged until I feel confident in the robustness of the systems.
Checklist