fix(chrome-ext): preserve cursor position in generic contenteditable replacement #2617
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Fixes #2616
Description
replaceGenericContentEditableusedel.textContent = value, which destroys DOM structure and loses cursor position. This affects editors like Notion that fall through to the generic handler.Now tries surgical replacement via
selectSpanInEditor+replaceTextInRangefirst, falling back to the original behavior if that fails.Also extracts
testBasicSuggestionRichTextandtestCanIgnoreRichTextSuggestionshared test utilities (matching the existingtestMultipleSuggestionsAndUndopattern) and adds cursor position verification to the basic suggestion test.How Has This Been Tested?
The basic suggestion test now verifies cursor position by using
ArrowRight×3 + Backspacefrom the expected cursor position.Checklist