Skip to content

Conversation

@obenland
Copy link
Member

It looks like RTL_Admin_Bar has been defunct since #11088 moved the initialization to admin_bar_init.

Fixes #17773.

Changes proposed in this Pull Request:

  • Removes RTL_Admin_Bar class.
  • Removes filter callback and hook that activated the class.

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

  • Navigate to https://wordpress.com/me/account and select a RTL language like Hebrew.
  • In Jetpack::get_connected_user_data() comment out the line that returns $cached_user_data.
  • On your Jetpack site under Settings > General, set your site language to a RTL language like Hebrew.
  • Reload wp-admin and make sure the masterbar renders in RTL.

Proposed changelog entry for your changes:

  • Removed unused class RTL_Admin_Bar.

@obenland obenland added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review This PR is ready for review. [Feature] Masterbar WordPress.com Toolbar and Dashboard customizations labels Nov 11, 2020
@obenland obenland requested review from a team and jeherve November 11, 2020 17:54
@obenland obenland self-assigned this Nov 11, 2020
@jetpackbot
Copy link
Collaborator

Scheduled Jetpack release: December 1, 2020.
Scheduled code freeze: November 23, 2020

E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-17781

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Generated by 🚫 dangerJS against c115193

@jeherve jeherve added this to the 9.2 milestone Nov 11, 2020
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Nov 11, 2020
@obenland obenland merged commit 4e15d7b into master Nov 11, 2020
@obenland obenland deleted the remove/rtl-admin-bar branch November 11, 2020 18:23
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Nov 11, 2020
obenland added a commit that referenced this pull request Nov 11, 2020
kraftbj pushed a commit that referenced this pull request Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Masterbar WordPress.com Toolbar and Dashboard customizations [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider whether RTL_Admin_Bar is still required in masterbar module

6 participants