-
Notifications
You must be signed in to change notification settings - Fork 826
Subscribe and button blocks: Add email rendering for WC Email Editor #45006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryCoverage changed in 2 files.
Full summary · PHP report · JS report Coverage check overridden by
I don't care about code coverage for this PR
|
A couple of thoughts:
|
I'll try it out, thanks for the suggestion! We do support |
59da532
to
dd0e3c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The button and jetpack/subscriptions
work pretty well overall - nice work! I just noticed a few minor styling issues and left comments on those.
projects/plugins/jetpack/extensions/blocks/subscriptions/subscriptions.php
Outdated
Show resolved
Hide resolved
adf3ca9
to
68ce7ae
Compare
610f685
to
930f395
Compare
…45006) * Subscribe and button blocks: Add WC email rendering.
Fixes https://linear.app/a8c/issue/CML-770/fix-subscribe-block
Fixes https://linear.app/a8c/issue/CML-860/fix-email-rendering-for-buttons
Proposed changes:
This PR adds email rendering for the Jetpack button block, using the core/button block email rendering already available in the WC Email Editor package. We then use the button block email rendering in the subscribe block. Also adds tests.
Known issue: the core button block rendering doesn't support gradients. We can follow up on that in the package.
Other information:
Jetpack product discussion
https://linear.app/a8c/project/switch-to-centralized-email-rendering-solution-aacb0b060431/issues?layout=list&ordering=priority&grouping=workflowState&subGrouping=none&showCompletedIssues=all&showSubIssues=true&showTriageIssues=false
Does this pull request change what data or activity we track or use?
N/A
Testing instructions:
bin/jetpack-downloader test jetpack add/subscribe-block-wc-email-rendering
.wc-email-editor
sticker to a test site. See PCYsg-eQj-p2Notes: