Conversation
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryCoverage changed in 1 file.
Full summary · PHP report · JS report Coverage check overridden by
I don't care about code coverage for this PR
|
grzegorz-cp
left a comment
There was a problem hiding this comment.
Lis looks good to me.
I also tested the scenarios from #44772
When running something like
wp site emptyon WP Cloud sites, it gives a PHP fatal.This seems to have been introduced in 123e2a0 (see #44772).
After much trial and error, I found that deferring the schema generation to a callback seems to work fine, but I'm not familiar with endpoints or the implications of making this change, and have no idea why it works, particularly because effectively the exact same thing happens in the
argskey.Proposed changes:
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
wp site emptyshould work fine with this branch, but I'm not sure how to test for regressions.