Skip to content

Fix PHP fatal when running WP-CLI#45045

Merged
tbradsha merged 2 commits intotrunkfrom
try/fix_WP-CLI_fatal
Sep 2, 2025
Merged

Fix PHP fatal when running WP-CLI#45045
tbradsha merged 2 commits intotrunkfrom
try/fix_WP-CLI_fatal

Conversation

@tbradsha
Copy link
Contributor

@tbradsha tbradsha commented Sep 2, 2025

When running something like wp site empty on WP Cloud sites, it gives a PHP fatal.

This seems to have been introduced in 123e2a0 (see #44772).

After much trial and error, I found that deferring the schema generation to a callback seems to work fine, but I'm not familiar with endpoints or the implications of making this change, and have no idea why it works, particularly because effectively the exact same thing happens in the args key.

Proposed changes:

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

wp site empty should work fine with this branch, but I'm not sure how to test for regressions.

@tbradsha tbradsha requested a review from a team September 2, 2025 17:35
@tbradsha tbradsha self-assigned this Sep 2, 2025
@tbradsha tbradsha added [Status] Needs Review This PR is ready for review. Bug labels Sep 2, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the try/fix_WP-CLI_fatal branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack try/fix_WP-CLI_fatal

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Package] My Jetpack [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Sep 2, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Jetpack plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. and removed [Status] Needs Review This PR is ready for review. labels Sep 2, 2025
@tbradsha tbradsha added Bug When a feature is broken and / or not performing as intended [Status] Needs Review This PR is ready for review. and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. Bug labels Sep 2, 2025
@jp-launch-control
Copy link

jp-launch-control bot commented Sep 2, 2025

Code Coverage Summary

Coverage changed in 1 file.

File Coverage Δ% Δ Uncovered
projects/packages/my-jetpack/src/class-rest-products.php 158/256 (61.72%) -6.91% 18 💔

Full summary · PHP report · JS report

Coverage check overridden by I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. .

Copy link
Contributor

@grzegorz-cp grzegorz-cp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lis looks good to me.
I also tested the scenarios from #44772

@grzegorz-cp grzegorz-cp added the I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. label Sep 2, 2025
@tbradsha tbradsha merged commit 4002cc9 into trunk Sep 2, 2025
96 of 98 checks passed
@tbradsha tbradsha deleted the try/fix_WP-CLI_fatal branch September 2, 2025 22:40
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug When a feature is broken and / or not performing as intended I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. [Package] My Jetpack [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants