Skip to content

Prevent PHP error on invalid excluded extensions check#45046

Merged
tbradsha merged 1 commit intotrunkfrom
fix/jetpack/fatal_on_invalid_excluded_extensions
Sep 2, 2025
Merged

Prevent PHP error on invalid excluded extensions check#45046
tbradsha merged 1 commit intotrunkfrom
fix/jetpack/fatal_on_invalid_excluded_extensions

Conversation

@tbradsha
Copy link
Contributor

@tbradsha tbradsha commented Sep 2, 2025

Closes MONOREP-95

We had a spike of these:

PHP Fatal error: Uncaught TypeError: array_diff(): Argument #2 must be of type array, string given in /wordpress/plugins/jetpack/15.0-a.7/class.jetpack-gutenberg.php:331

This PR adds a check to verify the option returned is an array.

Proposed changes:

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Go to '..'

@tbradsha tbradsha requested a review from a team September 2, 2025 20:03
@tbradsha tbradsha self-assigned this Sep 2, 2025
@tbradsha tbradsha added [Status] Needs Review This PR is ready for review. [Type] Janitorial labels Sep 2, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the fix/jetpack/fatal_on_invalid_excluded_extensions branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack fix/jetpack/fatal_on_invalid_excluded_extensions

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Sep 2, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Jetpack plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@jp-launch-control
Copy link

Code Coverage Summary

Coverage changed in 1 file.

File Coverage Δ% Δ Uncovered
projects/plugins/jetpack/class.jetpack-gutenberg.php 167/459 (36.38%) 0.06% 1 ❤️‍🩹

Full summary · PHP report · JS report

@tbradsha tbradsha merged commit fd25b3d into trunk Sep 2, 2025
72 of 73 checks passed
@tbradsha tbradsha deleted the fix/jetpack/fatal_on_invalid_excluded_extensions branch September 2, 2025 20:45
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Type] Janitorial

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant