Phan: Fix PhanTypeMismatchArgument violations

[tbradsha]

Closes MONOREP-96

This addresses some of the less complicated violations of these rules:

• PhanTypeMismatchArgumentInternal
• PhanTypeMismatchArgumentInternalProbablyReal
• PhanTypeMismatchArgumentInternalReal

Proposed changes:

Changes made included the following:

• Incorrect PHPDoc (e.g. array → string)
• Outright invalid params (e.g. ARRAY_A as the second param of json_decode())
• Flipped params (e.g. header( $m, 500, true ); → header( $m, true, 500 );)
• Removed unnecessary calls (e.g. json_decode( false ); → false)
• Some explicit type casting
• Conditions to check type

I also suppressed an instance or two of setcookie() where the value was set to false, which is a valid way to mark a cookie for deletion despite Phan not agreeing.

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

CI should still pass.

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the fix/phan/PhanTypeMismatchArgumentInternal branch.
• To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack fix/phan/PhanTypeMismatchArgumentInternal

bin/jetpack-downloader test jetpack-mu-wpcom-plugin fix/phan/PhanTypeMismatchArgumentInternal

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  
• ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
3. You can use GitHub's Reviewers functionality to request a review.
4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

---

Jetpack plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

---

Vaultpress plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

---

Super Cache plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

---

Inspect plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

[jp-launch-control]

Code Coverage Summary

Coverage changed in 1 file.

File	Coverage	Δ%	Δ Uncovered
projects/packages/videopress/src/tus/class-tus-abstract-cache.php	0/50 (0.00%)	0.00%	2 ❤️‍🩹

Full summary · PHP report · JS report

[manzoorwanijk]

Looks great. Thank you for cleaning things up.