-
Notifications
You must be signed in to change notification settings - Fork 834
Slideshow block: ensure image size selection works correctly #45500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryCoverage changed in 1 file.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this, Karen!
I was able to reproduce the bug and confirm that the fix works with an exception when transitioning from anything to "Large". For example I tried switching from "Large" to "Thumbnail" and it works well. But then when I switched again to "Large" nothing happened. Can you also reproduce this?
Thanks for testing! No, I can't reproduce that. Which environment were you testing in? |
Testing with a WoA dev site, apologies for not specifying this in the first place. |
…or medium size) defined.
Noting here that the issue was the image sizes used on the test site - the image sizes on the test site were only 700 x 700px, and the large image size as defined in media settings on the site and most sites is set by default to 1024 x 1024. I would imagine this was probably the same behaviour before but can't confirm that - the code would suggest so. In that case it makes sense - no 'large' image size actually exists for that image, so there is nothing to select. |
Fixes VULCAN-310
Proposed changes:
Other information:
Jetpack product discussion
n/a
Does this pull request change what data or activity we track or use?
Testing instructions:
To replicate the issue:
To test the fix:
Note for Simple: Thumbnail size may not be 150 x 150 - this is not related to the Slideshow block. You can confirm by adding an image block and setting the resolution to thumbnail - the image thumbnail will look the same.