Skip to content

Conversation

@tbradsha
Copy link
Contributor

@tbradsha tbradsha commented Oct 15, 2025

Closes MONOREP-149

As per request here: pdWQjU-1qh-p2

More discussion here: p1760537475717319-slack-C7YPW6K40

Proposed changes:

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Go to '..'

@github-actions
Copy link
Contributor

github-actions bot commented Oct 15, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Wpcloud Sso plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@tbradsha tbradsha marked this pull request as ready for review October 15, 2025 17:27
@tbradsha tbradsha added DO NOT MERGE don't merge it! and removed [Status] Needs Review This PR is ready for review. labels Oct 15, 2025
@tbradsha tbradsha force-pushed the add/wpcloud-sso_plugin branch from 320ae52 to 51eb276 Compare October 23, 2025 19:07
@tbradsha tbradsha added [Status] Needs Review This PR is ready for review. and removed DO NOT MERGE don't merge it! [Status] In Progress labels Oct 23, 2025
mdbitz
mdbitz previously approved these changes Oct 29, 2025
Copy link
Contributor

@mdbitz mdbitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thomas, I tested this out on Jurassic.Ninja and it looks good, what remaning steps are there to get an initial 0.1 version created?

@tbradsha tbradsha force-pushed the add/wpcloud-sso_plugin branch from 51eb276 to f8fc39e Compare October 29, 2025 15:08
@tbradsha
Copy link
Contributor Author

I've rebased and fixed the lockfile, so if all passes, let's merge it!

@tbradsha tbradsha merged commit 8204985 into trunk Oct 29, 2025
90 checks passed
@tbradsha tbradsha deleted the add/wpcloud-sso_plugin branch October 29, 2025 15:25
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants