Skip to content

Conversation

@enejb
Copy link
Member

@enejb enejb commented Oct 16, 2025

Part of FORMS-367

⚠️ THIS IS A VERY MUCH AN EXPLORATORY PR AND IS NOT MEANT TO BE MERGED.

Screenshot 2025-10-16 at 10 35 57 AM Screenshot 2025-10-16 at 10 48 47 AM

In line with #41561 and #41191 explorations.

This PR is different in that it was mostly vibe coded and has a lot of the peices already in place. That I think we should have in the final implementation.

  1. Be able to create a form via the block editor in a page, post or site editor. You should care that you are building a form.
  2. You can see all your forms in one place.

It implements a UI in the dashboard.
When you add a new form to the editor it creates a form id stores the form in the custom post type.

Things that sort of work.

  • You can name a form.
  • You can duplicate a form.
  • You can add a new form via the same way.

Some really nice to haves. If we migrate forks to this central management system. We can support more editors.

Things that will be a real challenge.

  1. How do we migrate folks from previous forms ( that includes shortcodes ) to this new block based forms.
  2. How to migrate previous feedback data from one form to another? Do we merge it? There could be a lot of edge cases.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

No

Testing instructions:

On a page or post.
add a form.
Visit Jetpack > Forms > Forms tabs and notice the form there.

@github-actions
Copy link
Contributor

Are you an Automattician? The PR will need to be tested on WordPress.com. This comment will be updated with testing instructions as soon the build is complete.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Oct 16, 2025
@jp-launch-control
Copy link

Code Coverage Summary

Coverage changed in 3 files.

File Coverage Δ% Δ Uncovered
projects/packages/forms/src/blocks/contact-form/edit.tsx 0/274 (0.00%) 0.00% 6 💔
projects/packages/forms/src/dashboard/components/layout/index.tsx 0/32 (0.00%) 0.00% 1 ❤️‍🩹
projects/packages/forms/src/contact-form/class-contact-form-plugin.php 431/1316 (32.75%) 0.10% 0 💚

11 files are newly checked for coverage. Only the first 5 are listed here.

File Coverage
projects/packages/forms/src/blocks/contact-form/components/form-selector.tsx 0/53 (0.00%) 💔
projects/packages/forms/src/blocks/contact-form/hooks/use-form-loader.ts 0/29 (0.00%) 💔
projects/packages/forms/src/blocks/contact-form/hooks/use-form-ref.ts 0/26 (0.00%) 💔
projects/packages/forms/src/blocks/contact-form/hooks/use-form-sync.ts 0/27 (0.00%) 💔
projects/packages/forms/src/dashboard/forms/dataviews/actions.js 0/21 (0.00%) 💔

Full summary · PHP report · JS report

If appropriate, add one of these labels to override the failing coverage check: Covered by non-unit tests Use to ignore the Code coverage requirement check when E2Es or other non-unit tests cover the code Coverage tests to be added later Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage.

@enejb enejb changed the title Try: Add forms central managment Try: Add forms central management Oct 16, 2025
@simison simison added DO NOT MERGE don't merge it! [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Block] Contact Form Form block (also see Contact Form label) DO NOT MERGE don't merge it! Docs [Feature] Contact Form [Package] Forms [Status] In Progress [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants