-
Notifications
You must be signed in to change notification settings - Fork 838
Try: Add forms central management #45523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
| Are you an Automattician? The PR will need to be tested on WordPress.com. This comment will be updated with testing instructions as soon the build is complete. |
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
Code Coverage SummaryCoverage changed in 3 files.
11 files are newly checked for coverage. Only the first 5 are listed here.
Full summary · PHP report · JS report If appropriate, add one of these labels to override the failing coverage check:
Covered by non-unit tests
|
Part of FORMS-367
In line with #41561 and #41191 explorations.
This PR is different in that it was mostly vibe coded and has a lot of the peices already in place. That I think we should have in the final implementation.
It implements a UI in the dashboard.
When you add a new form to the editor it creates a form id stores the form in the custom post type.
Things that sort of work.
Some really nice to haves. If we migrate forks to this central management system. We can support more editors.
Things that will be a real challenge.
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
No
Testing instructions:
On a page or post.
add a form.
Visit Jetpack > Forms > Forms tabs and notice the form there.