Skip to content

Related Posts: Prevent PHP warnings when settings are malformed #45538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 20, 2025
Merged

Related Posts: Prevent PHP warnings when settings are malformed #45538

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3402701
Prevent warning when key is not set
tbradsha Oct 17, 2025
87240e9
More such warnings
tbradsha Oct 17, 2025
8c92df2
Add changelog
tbradsha Oct 17, 2025
d2a6923
Oops
tbradsha Oct 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions projects/plugins/jetpack/changelog/fix-related-posts-warnings
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: other

Related Posts: Prevent PHP errors when settings are malformed.
16 changes: 8 additions & 8 deletions projects/plugins/jetpack/modules/related-posts/jetpack-related-posts.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ public function action_frontend_init() {
public function get_headline() {
$options = $this->get_options();

if ( $options['show_headline'] ) {
if ( ! empty( $options['show_headline'] ) ) {
$headline = sprintf(
/** This filter is already documented in modules/sharedaddy/sharing-service.php */
apply_filters( 'jetpack_sharing_headline_html', '<h3 class="jp-relatedposts-headline"><em>%s</em></h3>', esc_html( $options['headline'] ), 'related-posts' ),
Expand Down Expand Up @@ -931,7 +931,7 @@ public function get_for_post_id( $post_id, array $args ) {
}

if (
! $options['enabled']
empty( $options['enabled'] )
|| 0 === (int) $post_id
|| empty( $options['size'] )
) {
Expand Down Expand Up @@ -1305,15 +1305,15 @@ protected function action_frontend_init_ajax( array $excludes ) {

$response = array(
'version' => self::VERSION,
'show_thumbnails' => (bool) $options['show_thumbnails'],
'show_date' => (bool) $options['show_date'],
'show_context' => (bool) $options['show_context'],
'layout' => (string) $options['layout'],
'headline' => (string) $options['headline'],
'show_thumbnails' => (bool) ( $options['show_thumbnails'] ?? false ),
'show_date' => (bool) ( $options['show_date'] ?? true ),
'show_context' => (bool) ( $options['show_context'] ?? true ),
'layout' => (string) ( $options['layout'] ?? 'grid' ),
'headline' => (string) ( $options['headline'] ?? '' ),
'items' => array(),
);

if ( count( $related_posts ) === $options['size'] ) {
if ( ! empty( $options['size'] ) && count( $related_posts ) === $options['size'] ) {
$response['items'] = $related_posts;
}

Expand Down
Loading