Skip to content

Forms: Fix renderable status of image select field #45542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 20, 2025
Merged

Forms: Fix renderable status of image select field #45542

merged 3 commits into from
Oct 20, 2025

Conversation

@dhasilva
Copy link
Contributor

@dhasilva dhasilva commented Oct 17, 2025

Follow-up to #45528

Proposed changes:

This fixes the case where no valid image option is present. In this case, the field is not rendered and its "required" status is ignored, just like the other fields with options

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Add a form with one image select field and another renderable field, like name or email
  • Set the image select field as required
  • Do not add images or labels to any option
  • Publish the form
  • Check that the field is not rendered
  • Check that you can submit the form by filling the other field

@dhasilva dhasilva requested a review from a team October 17, 2025 23:56
@dhasilva dhasilva self-assigned this Oct 17, 2025
@dhasilva dhasilva added [Status] Needs Review This PR is ready for review. [Type] Task labels Oct 17, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2025 •
edited
Loading

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the update/forms-image-select-no-options branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack update/forms-image-select-no-options

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@jp-launch-control
Copy link

jp-launch-control bot commented Oct 18, 2025 •
edited
Loading

Code Coverage Summary

Coverage changed in 1 file.

File Coverage Δ% Δ Uncovered
projects/packages/forms/src/contact-form/class-contact-form-field.php 1081/1700 (63.59%) -0.04% 1 ❤️‍🩹

Full summary · PHP report · JS report

edanzer
edanzer reviewed Oct 18, 2025
View reviewed changes
Copy link
Contributor

@edanzer edanzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix. I tested the image select field in general in case of regressions, and it works great. And I tested the empty image select on trunk vs this PR. Fix works as expected.

There's a testing issue. I think it just needs a test update.

Before - image select is empty but shows as required so cannot submit form
image-select-no-submit

After - empty image select doesn't show
image-select-can-submit

@dhasilva dhasilva merged commit dcef658 into trunk Oct 20, 2025
67 checks passed
@dhasilva dhasilva deleted the update/forms-image-select-no-options branch October 20, 2025 14:55
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@edanzer edanzer edanzer left review comments

Assignees

@dhasilva dhasilva

Labels

[Feature] Contact Form [Package] Forms [Tests] Includes Tests [Type] Task

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dhasilva @edanzer