Skip to content

Slideshow: Fix image sizing when parent height is not set #46450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
coder-karen merged 5 commits into from
Jan 12, 2026
Merged

Slideshow: Fix image sizing when parent height is not set #46450

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7dd8d22
Add an aspectRatio fallback if an image naturalWidth or height is not…
coder-karen Jan 6, 2026
02beb8e
changelog
coder-karen Jan 6, 2026
0371239
Update projects/plugins/jetpack/changelog/fix-jetpack-slideshow-aspec…
coder-karen Jan 7, 2026
5cb92aa
Update projects/plugins/jetpack/extensions/blocks/slideshow/swiper-ca…
coder-karen Jan 7, 2026
ff8f2c9
Merge remote-tracking branch 'origin/trunk' into fix/jetpack-slidesho…
coder-karen Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions projects/plugins/jetpack/changelog/fix-jetpack-slideshow-aspectRatio-fallback
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: bugfix

Slideshow: Ensureslideshows do not stretch to parent container width on mobile if no list height is set.
3 changes: 2 additions & 1 deletion projects/plugins/jetpack/extensions/blocks/slideshow/swiper-callbacks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,8 @@ function swiperResize( swiper ) {
if ( ! img ) {
return;
}
const aspectRatio = img.naturalWidth / img.naturalHeight;
const hasNatural = img && img.naturalWidth > 0 && img.naturalHeight > 0;
const aspectRatio = hasNatural ? img.naturalWidth / img.naturalHeight : SIXTEEN_BY_NINE;
const sanityAspectRatio = Math.max( Math.min( aspectRatio, SIXTEEN_BY_NINE ), 1 );
const sanityHeight =
typeof window !== 'undefined'
Expand Down
Loading