Jetpack CLI: check and update monorepo docker image automatically once a day#46460
Jetpack CLI: check and update monorepo docker image automatically once a day#46460
Conversation
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
Per code review feedback, use bash builtin [[ ]] syntax instead of POSIX [ ] for all conditionals in new code. This is more robust and follows bash scripting best practices.
|
Thanks for the review @anomiex! ✅ Updated all 6 instances to use Regarding Note: I know I just said this, but I'm letting the AI tooling still post this as part of testing these tools. |
anomiex
left a comment
There was a problem hiding this comment.
Seems reasonable, seems to work. One optional suggestion inline, feel free to ignore.
anomiex
left a comment
There was a problem hiding this comment.
LGTM. Might want to update the PR description to remove reference to the --latest-image flag, to avoid potential confusion later.
Proposed changes:
automattic/jetpack-monorepo:latestDocker imageFORCE_PULL=1environment variable to force an immediate image update checktools/docker/data/.monorepo-image-checkto avoid checking more than once per 24 hoursOther information:
Jetpack product discussion
N/A - Internal tooling improvement
Does this pull request change what data or activity we track or use?
No
Testing instructions:
Test automatic daily check:
rm tools/docker/data/.monorepo-image-checkjpcommand:jp --helpdocker pulljp --helpagain immediatelyls -la tools/docker/data/.monorepo-image-checkTest FORCE_PULL environment variable:
FORCE_PULL=1 jp installTest 24-hour expiry:
touch -t 202501010000 tools/docker/data/.monorepo-image-checkjp --version