-
Notifications
You must be signed in to change notification settings - Fork 849
AI Assistant: Fix site language parameter on sync AI request #46465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes the parameter naming in sync AI requests to use snake_case language_code instead of camelCase languageCode, ensuring consistency with the API expectations and the streaming version of the code.
Key Changes
- Modified the
askQuestionSyncfunction to transformlanguageCodetolanguage_codein the request body - Added a changelog entry documenting this patch fix
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| projects/js-packages/ai-client/src/ask-question/sync.ts | Adds transformation logic to convert languageCode option to language_code in the request body and removes the camelCase version |
| projects/js-packages/ai-client/changelog/fix-jetpack-ai-language-sync | Adds changelog entry for the patch fix |
Code Coverage SummaryCoverage changed in 2 files.
Full summary · PHP report · JS report If appropriate, add one of these labels to override the failing coverage check:
Covered by non-unit tests
|
c640e50 to
3756a8b
Compare
Follow-up to #46420
Proposed changes:
language_codebody value on sync requests like image captionOther information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions: