Skip to content

Conversation

@dhasilva
Copy link
Contributor

@dhasilva dhasilva commented Jan 7, 2026

Follow-up to #46420

Proposed changes:

  • Fixes the casing of the expected language_code body value on sync requests like image caption

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Send a sync AI request like image caption request
  • Check that the request body now has a language_code value instead of languageCode

@dhasilva dhasilva requested a review from a team January 7, 2026 00:29
@dhasilva dhasilva self-assigned this Jan 7, 2026
@dhasilva dhasilva added the [Type] Bug When a feature is broken and / or not performing as intended label Jan 7, 2026
Copilot AI review requested due to automatic review settings January 7, 2026 00:29
@dhasilva dhasilva added the [Status] Needs Review This PR is ready for review. label Jan 7, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2026

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the fix/jetpack-ai-language-sync branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack fix/jetpack-ai-language-sync

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2026

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the parameter naming in sync AI requests to use snake_case language_code instead of camelCase languageCode, ensuring consistency with the API expectations and the streaming version of the code.

Key Changes

  • Modified the askQuestionSync function to transform languageCode to language_code in the request body
  • Added a changelog entry documenting this patch fix

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
projects/js-packages/ai-client/src/ask-question/sync.ts Adds transformation logic to convert languageCode option to language_code in the request body and removes the camelCase version
projects/js-packages/ai-client/changelog/fix-jetpack-ai-language-sync Adds changelog entry for the patch fix

@jp-launch-control
Copy link

jp-launch-control bot commented Jan 7, 2026

Code Coverage Summary

Coverage changed in 2 files.

File Coverage Δ% Δ Uncovered
projects/packages/jetpack-mu-wpcom/src/features/holiday-snow/class-holiday-snow.php 73/171 (42.69%) -4.68% 8 💔
projects/js-packages/ai-client/src/ask-question/sync.ts 0/22 (0.00%) 0.00% 1 ❤️‍🩹

Full summary · PHP report · JS report

If appropriate, add one of these labels to override the failing coverage check: Covered by non-unit tests Use to ignore the Code coverage requirement check when E2Es or other non-unit tests cover the code Coverage tests to be added later Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage.

@dhasilva dhasilva force-pushed the fix/jetpack-ai-language-sync branch from c640e50 to 3756a8b Compare January 7, 2026 00:49
@dhasilva dhasilva merged commit a3795e3 into trunk Jan 7, 2026
71 of 72 checks passed
@dhasilva dhasilva deleted the fix/jetpack-ai-language-sync branch January 7, 2026 01:04
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[JS Package] AI Client RNA [Type] Bug When a feature is broken and / or not performing as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants