WooCommerce Analytics: Fix product_purchase event not tracking for shortcode checkout

[chihsuan]

Fixes WOOA7S-929

Proposed changes:

• Fix product_purchase event not tracking for shortcode checkout due to incorrect order ID type check

Root Cause Analysis

The order_process() method handles two different hooks:

• woocommerce_checkout_order_processed (shortcode checkout) - passes integer order ID
• woocommerce_store_api_checkout_order_processed (block checkout) - passes WC_Order object

The code was checking:

if ( is_string( $order_id_or_order ) ) {
    $order = wc_get_order( $order_id_or_order );
} else {
    $order = $order_id_or_order;
}

When the shortcode checkout hook fires with an integer (e.g., 12345), is_string(12345) returns false, so the code takes the else branch and treats the integer as the order object. This then fails the instanceof WC_Order check and the function returns early, silently dropping all product_purchase events for shortcode checkout.

Fix

Simplified the code by directly using wc_get_order() which already handles int, string, and WC_Order inputs:

$order = wc_get_order( $order_id_or_order );

if ( ! $order ) {
    return;
}

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

N/A

Does this pull request change what data or activity we track or use?

No - this fixes a bug where events were being silently dropped.

Testing instructions:

1. Set up a WooCommerce store with Jetpack connected and WooCommerce Analytics enabled
2. Add the following code snippet to your theme's functions.php or use a code snippet plugin:

add_filter( 'jetpack_woocommerce_analytics_event_props', function( $event_properties, $event_name ) {
    error_log( 'Tracks event: ' . $event_name . ' ' . print_r( $event_properties, true ) );
    return $event_properties;
}, 10, 2 );

3. Open a terminal and navigate to your WordPress site root directory. Run tail -f wp-content/debug.log to monitor debug logs
4. Complete a checkout using the shortcode checkout (not block checkout)
5. Verify that the product_purchase event appears in the debug log

Before this fix: No product_purchase event would be logged for shortcode checkout
After this fix: The product_purchase event is properly tracked

🤖 Generated with Claude Code

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the fix/woocommerce-analytics-product-purchase-order-id-type branch.
• To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack fix/woocommerce-analytics-product-purchase-order-id-type

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  
• ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
3. You can use GitHub's Reviewers functionality to request a review.
4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

---

Jetpack plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

[Copilot]

Pull request overview

This PR fixes a bug where the product_purchase analytics event was not being tracked for WooCommerce shortcode checkout. The issue stemmed from an incorrect type check that expected a string order ID but received an integer from the woocommerce_checkout_order_processed hook.

Key changes:

• Changed the type check in order_process() from is_string() to is_numeric() to handle both integer and string order IDs
• Updated the PHPDoc to reflect that the parameter can be int|string|WC_Order

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
projects/packages/woocommerce-analytics/src/class-universal.php	Fixed type check to use is_numeric() instead of is_string() and updated PHPDoc to include int type
projects/packages/woocommerce-analytics/changelog/fix-product-purchase-order-id-type-check	Added changelog entry documenting the bug fix

The fix is correct and well-implemented. The change from is_string() to is_numeric() properly handles order IDs passed as either integers (from woocommerce_checkout_order_processed) or strings, while still allowing WC_Order objects to fall through to the else branch. The subsequent instanceof WC_Order check ensures that invalid inputs are safely rejected.

[jp-launch-control]

Code Coverage Summary

Coverage changed in 2 files.

File	Coverage	Δ%	Δ Uncovered
projects/packages/woocommerce-analytics/src/class-woo-analytics-trait.php	0/267 (0.00%)	0.00%	-1 💚
projects/packages/woocommerce-analytics/src/class-universal.php	3/360 (0.83%)	0.83%	-11 💚

Full summary · PHP report · JS report

[Copilot]

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

[Copilot]

Pull request overview

Copilot reviewed 10 out of 11 changed files in this pull request and generated 3 comments.

[Copilot]

Pull request overview

Copilot reviewed 10 out of 11 changed files in this pull request and generated no new comments.

[kangzj]

It works as described and nice work adding more tests to cover the cases here!