Skip to content

Conversation

@dhasilva
Copy link
Contributor

@dhasilva dhasilva commented Jan 8, 2026

Follow-up to #46206 and #46377

Proposed changes:

  • Updates the @wordpress/build to a version with a fix for pnpm projects
  • Fixes a 403 issue when registering the URL directly instead of a slug by adding a root redirect

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Enable the jetpack_forms_alpha flag
  • (cd projects/packages/forms && pnpm run build:wp-build)
  • Open WP Admin
  • Check that there is a Forms (WP-Build) entry under the Jetpack menu
  • Click on it
  • The dashboard should be displayed (has some issues and needs updating, but that is outside of the scope of this PR)

@dhasilva dhasilva requested a review from a team January 8, 2026 22:13
@dhasilva dhasilva self-assigned this Jan 8, 2026
@dhasilva dhasilva added the [Type] Bug When a feature is broken and / or not performing as intended label Jan 8, 2026
Copilot AI review requested due to automatic review settings January 8, 2026 22:13
@dhasilva dhasilva added the [Status] Needs Review This PR is ready for review. label Jan 8, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the update/forms-wp-build branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack update/forms-wp-build
bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/forms-wp-build

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the wp-build dashboard functionality by addressing a 403 error and updating the build package to support pnpm projects properly.

Key Changes:

  • Updates @wordpress/build to version 0.5.1-next.79a2f3cdd.0 which includes a fix for pnpm projects
  • Refactors admin menu registration to use a slug instead of a direct URL, preventing 403 errors
  • Adds a root route redirect from / to /responses/inbox to handle default navigation

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
projects/packages/forms/src/dashboard/class-dashboard.php Refactors menu registration to use slug-based approach with callback function instead of URL; improves naming from forms2 to forms_wpbuild
projects/packages/forms/routes/root/route.ts Adds new root route that redirects to default inbox view using @wordpress/route redirect
projects/packages/forms/routes/root/package.json Defines root route configuration for path / on jetpack-forms-responses page
projects/packages/forms/routes/responses/package.json Downgrades @wordpress/route from 0.3.0 to 0.2.0 for consistency
projects/packages/forms/package.json Updates @wordpress/build to pre-release version with pnpm fix
pnpm-lock.yaml Reflects package version updates and dependency resolution changes
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

@jp-launch-control
Copy link

Code Coverage Summary

Coverage changed in 1 file.

File Coverage Δ% Δ Uncovered
projects/packages/forms/src/dashboard/class-dashboard.php 24/117 (20.51%) -0.36% 2 ❤️‍🩹

Full summary · PHP report · JS report

"@wordpress/i18n": "6.10.0",
"@wordpress/icons": "11.4.0",
"@wordpress/notices": "5.37.0",
"@wordpress/route": "0.3.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why going to the previous version?

Copy link
Member

@simison simison Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could even test with 0.3.1-next.79a2f3cdd.0 latest bleeding edge.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consistency with the forms package's package.json, and due to @wordpress/build having 0.2.0 as peer dependency. We had 0.3.0 and it was downgraded here due to causing unmatched peer dependency errors. To update this, the peer dependency needs to be updated on @wordpress/build first.

Copy link
Member

@simison simison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely

@dhasilva dhasilva merged commit da3fc00 into trunk Jan 9, 2026
100 of 101 checks passed
@dhasilva dhasilva deleted the update/forms-wp-build branch January 9, 2026 18:13
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Contact Form [Package] Forms [Type] Bug When a feature is broken and / or not performing as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants