-
Notifications
You must be signed in to change notification settings - Fork 854
Forms: Add granular block categories to form editor #46626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 15 commits
947f75d
b8c01d2
908c680
ee438e4
72f8b4a
3d10469
1554021
b7db60e
1f610c9
54072db
bacabc0
02a169e
d5401e3
395ebbf
077dc15
ab43d37
61a960f
10bba56
8b09478
0b0dfc7
b0bb4c2
3d1779c
80fa393
03934cc
54e9886
9e367d1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| Significance: minor | ||
| Type: added | ||
|
|
||
| Added granular block categories for better organization of form fields in the block inserter on the Form Editor. | ||
enejb marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -67,7 +67,11 @@ public static function allowed_blocks_for_jetpack_form( $allowed_block_types, $e | |
| 'jetpack/field-rating', | ||
| 'jetpack/field-text', | ||
| 'jetpack/field-number', | ||
| 'jetpack/field-file-upload', | ||
| 'jetpack/field-hidden', | ||
| 'jetpack/field-file', | ||
| 'jetpack/field-time', | ||
| 'jetpack/field-slider', | ||
| 'jetpack/field-image-select', | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We have a lot of these lists for core blocks and fields; I'm pretty worried that they're hard to maintain and someone (especially from other teams) will forget to update one of them, and it's hard to notice. Plus it's just pain already to add new fields due to how many places/lists one needs to be mindful about. Ideally, we could consolidate them as much as possible; can be separate PR. |
||
|
|
||
| // Supporting blocks. | ||
| 'jetpack/button', | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we're missing |
||
|
|
@@ -76,6 +80,11 @@ public static function allowed_blocks_for_jetpack_form( $allowed_block_types, $e | |
| 'jetpack/options', | ||
| 'jetpack/option', | ||
| 'jetpack/phone-input', | ||
| 'jetpack/dropzone', | ||
| 'jetpack/input-range', | ||
| 'jetpack/input-rating', | ||
| 'jetpack/fieldset-image-options', | ||
| 'jetpack/input-image-option', | ||
|
|
||
| // Multistep blocks. | ||
| 'jetpack/form-step', | ||
|
|
@@ -86,6 +95,7 @@ public static function allowed_blocks_for_jetpack_form( $allowed_block_types, $e | |
|
|
||
| // Core blocks for rich content. | ||
| 'core/audio', | ||
| 'core/button', | ||
| 'core/columns', | ||
| 'core/column', | ||
| 'core/group', | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.