Jetpack CRM: Remove discontinued Skype Click 2 Call option#47154
Jetpack CRM: Remove discontinued Skype Click 2 Call option#47154
Conversation
This is a test PR created with Claude Code to explore the contribution workflow. Related issue: JETCRM-69 Skype was retired on May 5, 2025. This removes the Skype (callto:) option from the Click 2 Call settings and simplifies the code to always use tel:. Changes: - Remove Click 2 Call link type dropdown from settings - Simplify PHP function to always return tel: - Simplify JS function to always return tel: - Remove zbsClick2CallType variable declarations Note: Unable to fully test Click 2 Call links locally due to SQLite limitations in WordPress Studio. UI changes verified.
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 🔴 Action required: We would recommend that you add a section to the PR description to specify whether this PR includes any changes to data or privacy, like so: Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
Code Coverage SummaryCoverage changed in 5 files.
|
There was a problem hiding this comment.
Pull request overview
Removes the discontinued Skype callto: Click 2 Call option from Jetpack CRM by standardizing Click 2 Call links to always use the tel: protocol and removing the related admin setting/UI.
Changes:
- Simplify PHP/JS Click 2 Call URL generation to always return
tel:. - Remove the “Click 2 Call link type” setting and related JS variables injected into multiple admin views.
- Add a CRM changelog entry documenting the removal.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| projects/plugins/crm/js/ZeroBSCRM.admin.global.js | Removes callto: branching; always returns tel: URLs. |
| projects/plugins/crm/includes/ZeroBSCRM.TagManager.php | Stops injecting zbsClick2CallType into Tag Manager view JS. |
| projects/plugins/crm/includes/ZeroBSCRM.List.php | Stops injecting zbsClick2CallType into list view JS. |
| projects/plugins/crm/includes/ZeroBSCRM.Edit.php | Stops injecting zbsClick2CallType into edit view JS. |
| projects/plugins/crm/includes/ZeroBSCRM.Delete.php | Stops injecting zbsClick2CallType into delete view JS. |
| projects/plugins/crm/includes/ZeroBSCRM.DAL3.Helpers.php | Simplifies Click 2 Call prefix helper to always return tel:. |
| projects/plugins/crm/changelog/remove-skype-click2call-option | Adds changelog entry for removing Skype option. |
| projects/plugins/crm/admin/settings/general.page.php | Removes dropdown UI and POST handling for clicktocalltype. |
| @@ -7316,15 +7316,7 @@ function zeroBSCRM_db2_deleteGeneric( $id = -1, $tableKey = '' ) { | |||
|
|
|||
| // this has a js equivilent in global.js: zeroBSCRMJS_telURLFromNo | |||
There was a problem hiding this comment.
The comment has a spelling issue ("equivilent" → "equivalent") and references a non-existent file name ("global.js"). Since the JS function lives in js/ZeroBSCRM.admin.global.js, update the comment to avoid misleading future maintenance.
| // this has a js equivilent in global.js: zeroBSCRMJS_telURLFromNo | |
| // This has a JS equivalent in js/ZeroBSCRM.admin.global.js: zeroBSCRMJS_telURLFromNo |
| @@ -122,10 +122,6 @@ | |||
| if ( isset( $_POST['wpzbscrm_clicktocall'] ) && ! empty( $_POST['wpzbscrm_clicktocall'] ) ) { | |||
| $updatedSettings['clicktocall'] = 1; | |||
| } | |||
There was a problem hiding this comment.
Saving the General settings no longer touches clicktocalltype, so existing installs may keep an obsolete clicktocalltype value in the DB indefinitely. Consider explicitly resetting it to 1 (or deleting/unsetting it) during this settings save to keep persisted settings consistent with the new behavior.
| } | |
| } | |
| // Reset legacy click-to-call type to the default to avoid persisting obsolete values. | |
| $updatedSettings['clicktocalltype'] = 1; |
| Significance: patch | ||
| Type: removed | ||
|
|
||
| Click 2 Call: Remove discontinued Skype (callto:) option |
There was a problem hiding this comment.
Changelog entry should end with a period to match the repository changelog entry guidelines.
| Click 2 Call: Remove discontinued Skype (callto:) option | |
| Click 2 Call: Remove discontinued Skype (callto:) option. |
Summary
Skype was retired on May 5, 2025. This removes the Skype (callto:) option from Click 2 Call settings and simplifies the code to always use
tel:.Proposed changes:
zeroBSCRM_clickToCallPrefix()to always returntel:zeroBSCRMJS_telURLFromNo()to always returntel:+ telnozbsClick2CallTypevariable declarations from TagManager, Delete, List, and Edit filesOther information:
Testing instructions:
tel:protocolNote
Unable to fully test Click 2 Call links locally due to SQLite/MySQL compatibility issues in WordPress Studio. UI changes verified.