Skip to content

Jetpack CRM: Remove discontinued Skype Click 2 Call option#47154

Open
rudberga wants to merge 2 commits intotrunkfrom
remove-skype-click2call-option
Open

Jetpack CRM: Remove discontinued Skype Click 2 Call option#47154
rudberga wants to merge 2 commits intotrunkfrom
remove-skype-click2call-option

Conversation

@rudberga
Copy link

@rudberga rudberga commented Feb 17, 2026

Summary

Skype was retired on May 5, 2025. This removes the Skype (callto:) option from Click 2 Call settings and simplifies the code to always use tel:.

Proposed changes:

  • Remove "Click 2 Call link type" dropdown from settings (keep the "Show Click 2 Call links" checkbox)
  • Simplify PHP function zeroBSCRM_clickToCallPrefix() to always return tel:
  • Simplify JS function zeroBSCRMJS_telURLFromNo() to always return tel: + telno
  • Remove zbsClick2CallType variable declarations from TagManager, Delete, List, and Edit files

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable?

Testing instructions:

  1. Go to Jetpack CRM → Settings → General
  2. Verify the "Click 2 Call link type" dropdown is gone
  3. Verify "Show Click 2 Call links" checkbox still exists
  4. Create a contact with a phone number
  5. Enable "Show Click 2 Call links" in settings
  6. View the contact and verify phone link uses tel: protocol

Note

Unable to fully test Click 2 Call links locally due to SQLite/MySQL compatibility issues in WordPress Studio. UI changes verified.

This is a test PR created with Claude Code to explore the contribution workflow.
Related issue: JETCRM-69

Skype was retired on May 5, 2025. This removes the Skype (callto:) option
from the Click 2 Call settings and simplifies the code to always use tel:.

Changes:
- Remove Click 2 Call link type dropdown from settings
- Simplify PHP function to always return tel:
- Simplify JS function to always return tel:
- Remove zbsClick2CallType variable declarations

Note: Unable to fully test Click 2 Call links locally due to SQLite
limitations in WordPress Studio. UI changes verified.
@github-actions github-actions bot added [Plugin] CRM Issues about the Jetpack CRM plugin Admin Page React-powered dashboard under the Jetpack menu labels Feb 17, 2026
@github-actions
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • 🔴 Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • 🔴 Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


🔴 Action required: We would recommend that you add a section to the PR description to specify whether this PR includes any changes to data or privacy, like so:

## Does this pull request change what data or activity we track or use?

My PR adds *x* and *y*.

Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Feb 17, 2026
@jp-launch-control
Copy link

Code Coverage Summary

Coverage changed in 5 files.

File Coverage Δ% Δ Uncovered
projects/plugins/crm/includes/ZeroBSCRM.Delete.php 0/242 (0.00%) 0.00% -1 💚
projects/plugins/crm/includes/ZeroBSCRM.Edit.php 0/178 (0.00%) 0.00% -1 💚
projects/plugins/crm/includes/ZeroBSCRM.TagManager.php 0/144 (0.00%) 0.00% -1 💚
projects/plugins/crm/includes/ZeroBSCRM.DAL3.Helpers.php 0/2831 (0.00%) 0.00% -4 💚
projects/plugins/crm/admin/settings/general.page.php 0/392 (0.00%) 0.00% -16 💚

Full summary · PHP report

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the discontinued Skype callto: Click 2 Call option from Jetpack CRM by standardizing Click 2 Call links to always use the tel: protocol and removing the related admin setting/UI.

Changes:

  • Simplify PHP/JS Click 2 Call URL generation to always return tel:.
  • Remove the “Click 2 Call link type” setting and related JS variables injected into multiple admin views.
  • Add a CRM changelog entry documenting the removal.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
projects/plugins/crm/js/ZeroBSCRM.admin.global.js Removes callto: branching; always returns tel: URLs.
projects/plugins/crm/includes/ZeroBSCRM.TagManager.php Stops injecting zbsClick2CallType into Tag Manager view JS.
projects/plugins/crm/includes/ZeroBSCRM.List.php Stops injecting zbsClick2CallType into list view JS.
projects/plugins/crm/includes/ZeroBSCRM.Edit.php Stops injecting zbsClick2CallType into edit view JS.
projects/plugins/crm/includes/ZeroBSCRM.Delete.php Stops injecting zbsClick2CallType into delete view JS.
projects/plugins/crm/includes/ZeroBSCRM.DAL3.Helpers.php Simplifies Click 2 Call prefix helper to always return tel:.
projects/plugins/crm/changelog/remove-skype-click2call-option Adds changelog entry for removing Skype option.
projects/plugins/crm/admin/settings/general.page.php Removes dropdown UI and POST handling for clicktocalltype.

@@ -7316,15 +7316,7 @@ function zeroBSCRM_db2_deleteGeneric( $id = -1, $tableKey = '' ) {

// this has a js equivilent in global.js: zeroBSCRMJS_telURLFromNo
Copy link

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment has a spelling issue ("equivilent" → "equivalent") and references a non-existent file name ("global.js"). Since the JS function lives in js/ZeroBSCRM.admin.global.js, update the comment to avoid misleading future maintenance.

Suggested change
// this has a js equivilent in global.js: zeroBSCRMJS_telURLFromNo
// This has a JS equivalent in js/ZeroBSCRM.admin.global.js: zeroBSCRMJS_telURLFromNo

Copilot uses AI. Check for mistakes.
@@ -122,10 +122,6 @@
if ( isset( $_POST['wpzbscrm_clicktocall'] ) && ! empty( $_POST['wpzbscrm_clicktocall'] ) ) {
$updatedSettings['clicktocall'] = 1;
}
Copy link

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saving the General settings no longer touches clicktocalltype, so existing installs may keep an obsolete clicktocalltype value in the DB indefinitely. Consider explicitly resetting it to 1 (or deleting/unsetting it) during this settings save to keep persisted settings consistent with the new behavior.

Suggested change
}
}
// Reset legacy click-to-call type to the default to avoid persisting obsolete values.
$updatedSettings['clicktocalltype'] = 1;

Copilot uses AI. Check for mistakes.
Significance: patch
Type: removed

Click 2 Call: Remove discontinued Skype (callto:) option
Copy link

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog entry should end with a period to match the repository changelog entry guidelines.

Suggested change
Click 2 Call: Remove discontinued Skype (callto:) option
Click 2 Call: Remove discontinued Skype (callto:) option.

Copilot uses AI. Check for mistakes.
@rudberga rudberga changed the title Remove discontinued Skype Click 2 Call option Jetpack CRM: Remove discontinued Skype Click 2 Call option Feb 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Admin Page React-powered dashboard under the Jetpack menu [Plugin] CRM Issues about the Jetpack CRM plugin [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant