Skip to content

fix: set workdir properly#182

Merged
sjinks merged 2 commits intomainfrom
pltfrm-2043-vip-import-sql-fails-inside-directory-provided-in-app-code
Feb 26, 2026
Merged

fix: set workdir properly#182
sjinks merged 2 commits intomainfrom
pltfrm-2043-vip-import-sql-fails-inside-directory-provided-in-app-code

Conversation

@sjinks
Copy link
Member

@sjinks sjinks commented Feb 26, 2026

This pull request simplifies how the working directory is determined for Docker exec commands in the lando-tooling plugin. Instead of dynamically mapping the host's current working directory to the container, the code now always uses /app as the container's working directory unless a specific directory is provided.

Key changes:

Simplification of working directory logic:

  • Removed the getContainerPath helper function, which previously mapped the host's current directory to the container's /app directory.
  • Updated the buildCommand function to default the workdir option directly to /app instead of using the removed helper.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request removes the automatic mapping of the host's current working directory to the container's working directory in Lando tooling commands. The change simplifies the working directory logic by always defaulting to /app instead of dynamically calculating the corresponding container path based on where the command is invoked from on the host.

Changes:

  • Removed the getContainerPath helper function that mapped host paths to container paths
  • Modified buildCommand to use a static /app default for workdir instead of dynamic path mapping

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sjinks sjinks merged commit 83ccd88 into main Feb 26, 2026
18 checks passed
@sjinks sjinks deleted the pltfrm-2043-vip-import-sql-fails-inside-directory-provided-in-app-code branch February 26, 2026 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants