Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request removes the automatic mapping of the host's current working directory to the container's working directory in Lando tooling commands. The change simplifies the working directory logic by always defaulting to /app instead of dynamically calculating the corresponding container path based on where the command is invoked from on the host.
Changes:
- Removed the
getContainerPathhelper function that mapped host paths to container paths - Modified
buildCommandto use a static/appdefault for workdir instead of dynamic path mapping
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request simplifies how the working directory is determined for Docker exec commands in the
lando-toolingplugin. Instead of dynamically mapping the host's current working directory to the container, the code now always uses/appas the container's working directory unless a specific directory is provided.Key changes:
Simplification of working directory logic:
getContainerPathhelper function, which previously mapped the host's current directory to the container's/appdirectory.buildCommandfunction to default theworkdiroption directly to/appinstead of using the removed helper.