Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to the permission handling scripts in the Lando core plugins, focusing on safer operations and enhanced robustness. The main changes involve adding checks before performing ownership and permission modifications to avoid errors when directories are missing or not writable, and improving the handling of user home directories.
Permission handling improvements:
/helpersis writable before attempting to change file permissions inlando-entrypoint.sh, preventing errors when the directory is not writable.perm_sweep()inuser-perm-helpers.shto check if/usr/local/binexists before runningchown, reducing unnecessary errors./usr/localdirectories, checking for existence before runningfindcommands, and removed redundant sweeps for subdirectories.User home directory handling:
getentis available, and confirming the directory exists before running ownership changes, improving reliability and avoiding potential failures.Parameter usage correction:
perm_sweepinuser-perms.shto use the group ID variable directly, ensuring correct parameter passing.