Skip to content

fix: allow custom properties on QueryFilter objects (gh-15854) #15856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: allow custom properties on QueryFilter objects (gh-15854) #15856

wants to merge 1 commit into from

Conversation

@shalini-saloni
Copy link

@shalini-saloni shalini-saloni commented Dec 3, 2025

Fixes #15854

Description

This PR fixes an issue where TypeScript would throw an error when trying to access custom properties on QueryFilter objects.

Changes

  • Modified _QueryFilter type definition in types/query.d.ts to include & Record<string, any>, allowing custom properties
  • Added test case gh15854() in test/types/queries.test.ts to verify the fix

Testing

  • All TypeScript type tests pass (npm run test-tsd)
  • The new test case verifies that custom properties can be accessed without TypeScript errors

@AbdelrahmanHafez AbdelrahmanHafez added the needs clarification This issue doesn't have enough information to be actionable. Close after 14 days of inactivity label Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

needs clarification This issue doesn't have enough information to be actionable. Close after 14 days of inactivity

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Can't access custom props of QueryFilter objects

2 participants

@shalini-saloni @AbdelrahmanHafez