fix: clear setTimeout in buffered syncCollectionMethods with callbacks #15871
+7
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When
syncCollectionMethods(find,watch,aggregate) were called with a callback while buffering was enabled, the buffer timeout was never cleared after the operation completed successfully. This causedsetTimeoutreferences to accumulate in memory, leading to a memory leak.The root cause was in
lib/drivers/node-mongodb-native/collection.jslines 140-142, where the callback was not wrapped to callclearTimeout()- unlike all other buffered operation paths which properly clear the timeout.Examples
Before this fix, the following code would leak memory:
After this fix,
clearTimeout()is properly called when the operation completes, preventing the memory leak.Fixes #15851